core: reduce DevTools flakiness #14782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
changed the title
Page.getFrameTree usage
connorjclark
approved these changes
Feb 14, 2023
adamraine
changed the title
adamraine
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14662 has returned. I've only seen it in this one location when we call
Page.getFrameTree. We can actually remove this call and replace it with aparentIdcheck.Also added a pause in bf-cache-failures at the end so there is a guaranteed buffer period between the history restoration and the gatherer cleanup phase.
Should help with the resurgence in e2e tests flakiness.
Fixes #14662