Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(largest-contentful-paint-element): add phases table #14891

Merged
merged 17 commits into from
May 3, 2023

Conversation

adamraine
Copy link
Member

@adamraine adamraine commented Mar 14, 2023

馃敀 doc

This includes the phase calculations for simulated and DT throttling.

TODOs before ready to merge:

  • Analyze lantern accuracy
  • Computed artifact for phases
  • Algorithm cleanup

TODO before releasing:


Example:

Screenshot 2023-04-25 at 4 42 05 PM

@adamraine adamraine mentioned this pull request Mar 23, 2023
4 tasks
@adamraine adamraine changed the title WIP: lcp phases breakdown core(lcp-element): add lcp phases table Apr 25, 2023
@adamraine adamraine marked this pull request as ready for review April 25, 2023 23:48
@adamraine adamraine requested a review from a team as a code owner April 25, 2023 23:48
@adamraine adamraine requested review from brendankenny and removed request for a team April 25, 2023 23:48
@connorjclark connorjclark changed the title core(lcp-element): add lcp phases table core(largest-contentful-paint-element): add phases table May 3, 2023
@devtools-bot devtools-bot merged commit 40c1608 into main May 3, 2023
31 checks passed
@devtools-bot devtools-bot deleted the lcp-phases-breakdown branch May 3, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants