core: collect fetchpriority for images and link rel preload #14925
Conversation
| @@ -219,8 +219,7 @@ <h2 id="toppy" style="background-image:url('');">Do better web tester page</h2> | |||
| <!-- FAIL(image-aspect-ratio): image is naturally 1024x680 --> | |||
| <img src="lighthouse-1024x680.jpg?iar1" width="120" height="15"> | |||
| <!-- PASS(image-aspect-ratio) --> | |||
| <!-- FAIL(lcp-lazy-loaded) --> | |||
There was a problem hiding this comment.
old comment; this isn't the LCP and doesn't fail that audit :)
| attributeHeight: '80', | ||
| naturalDimensions: { | ||
| width: 1024, | ||
| height: 678, |
There was a problem hiding this comment.
notice the image is called lighthouse-1024x680.jpg... :P
There was a problem hiding this comment.
So the file name is just misleading?
There was a problem hiding this comment.
So the file name is just misleading?
yes, but to be fair, it's copied from the byte-efficiency smoke test image of the same name, which is (we're now learning) also actually 1024x678, added wayyyy back in #1635
There was a problem hiding this comment.
Yeah not suggesting we change it here, just wanted to confirm
| attributeHeight: '80', | ||
| naturalDimensions: { | ||
| width: 1024, | ||
| height: 678, |
There was a problem hiding this comment.
So the file name is just misleading?
| @@ -70,6 +70,8 @@ function getLinkElementsInDOM() { | |||
| crossOrigin: link.crossOrigin, | |||
| hrefRaw, | |||
| source, | |||
| // @ts-expect-error - Not in tsc types yet. | |||
| fetchPriority: link.fetchPriority, | |||
There was a problem hiding this comment.
Is it possible to add an internal type declaration for this?
There was a problem hiding this comment.
Is it possible to add an internal type declaration for this?
Yeah, it felt like overkill because it's part of the html spec and so it will eventually get rolled up into the tsc types, but OTOH @ts-expect-error is pretty heavy handed. Added to the DOM types in the somewhat misleadingly named node.d.ts
To support #13738, gathers the
fetchpriorityhint in the ImageElements and LinkElements gatherers. Not used yet, but asserted in smoke tests.