fix(unused-css-rules): remove stylesheet preview for sheets with URL #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before: After: |
ebidel
approved these changes
Jan 19, 2017
ebidel
reviewed
Jan 19, 2017
| let url = stylesheetInfo.header.sourceURL; | ||
| const label = `${percentUsed}% rules used`; | ||
|
|
||
| if (!url || url === pageUrl) { |
There was a problem hiding this comment.
One thing I was curious about for later. When is url blank vs. the same as the page? Can you add a comment?
There was a problem hiding this comment.
Oh whoops Brendan merged before I could :) it seems to be if it was in the original document or added later with script, which maybe a more sophisticated version later on could identify the URL of the script that added it too? I'll add the TODO in my upcoming rules -> bytes conversion PR for CSS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @ebidel
addresses #1456