Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify package.json scripts to use bash/node explicitly. #1510

Merged
merged 1 commit into from
Jan 25, 2017
Merged

Modify package.json scripts to use bash/node explicitly. #1510

merged 1 commit into from
Jan 25, 2017

Conversation

XhmikosR
Copy link
Contributor

Shebangs don't work on Windows.

Part of the ongoing work to have tests pass on Windows.

@XhmikosR
Copy link
Contributor Author

Any updates on this?

brendankenny
brendankenny approved these changes Jan 25, 2017
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⌨️

@ebidel ebidel merged commit fd90f5c into GoogleChrome:master Jan 25, 2017
@XhmikosR XhmikosR deleted the pck-exec branch January 25, 2017 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebidel ebidel ebidel approved these changes

@brendankenny brendankenny brendankenny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@XhmikosR @ebidel @brendankenny