Move --harmony addition to smokehouse/offline-local/run-tests.sh.

[XhmikosR]

No description provided.

[XhmikosR]

So apparently the flag is still needed; reverted that patch.

[XhmikosR]

I don't seem to be able to get this right; I'm missing some parts in my understanding regarding tests.

So, if someone could take care of this, that would be better. We need to get rid of $__node_harmony from package.json so that it works on Windows too.

[brendankenny]

smokehouse was node v4 compliant, but looks like the issue is that we brought log into smokehouse to use the cross platform unicode/console stuff, but log is not node v4 (without --harmony) compliant :)

[XhmikosR]

Hmm, so I guess this patch is moot... I was just trying to get rid of the environment variable from package.json to no avail. :/ On Jan 24, 2017 22:12, "Brendan Kenny" <notifications@github.com> wrote: smokehouse was node v4 compliant, but looks like the issue is that we brought log into smokehouse to use the cross platform unicode/console stuff, but log is *not* node v4 (without --harmony) compliant :) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1511 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVVtchj35vihk-pMcEOYPLb-lWmeyk8ks5rVlsegaJpZM4LqYO5> .

[brendankenny]

Sorry this has been such a pain. Closing as this will be taken care of by #1519 now.