tests(a11y): use regex for target size explanation #15231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
commented
Jul 7, 2023
| @@ -859,7 +859,8 @@ const expectations = { | |||
| 'type': 'node', | |||
| 'selector': 'body > section > span#target-size-2', | |||
| 'snippet': '<span role="button" tabindex="0" id="target-size-2">', | |||
| 'explanation': 'Fix any of the following:\n Target has insufficient size (8px by 17px, should be at least 24px by 24px)\n Target has insufficient offset from its closest neighbor (12px should be at least 24px)', | |||
| // Exact target size can vary depending on the device. | |||
| 'explanation': /^Fix any of the following:\n {2}Target has insufficient size \([0-9]+px by [0-9]+px, should be at least 24px by 24px\)\n {2}Target has insufficient offset from its closest neighbor \([0-9]+px should be at least 24px\)$/, | |||
There was a problem hiding this comment.
I used {2} because of https://eslint.org/docs/latest/rules/no-regex-spaces
There was a problem hiding this comment.
The goal was to match the exact string as much as possible. \s+ could be any number of any whitespace whereas this only matches exactly two spaces.
Doesn't matter to me much but this is what eslint recommended when I copied the string into the regex.
|
This is the sort of thing we expect our emulation settings (viewport and DPI) to control for, isn't it? |
|
It may just be outside the control of our emulation settings. From what I can tell it could be the way fonts are rendered on different devices. The difference in size is never more than 1-2px. |
connorjclark
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exact target sizes vary depending on the device. For example, the failing target was 8px by 18px on my macbook.