core: remove config navigations #15397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "pauseAfterFcpMs": 1000, | ||
| "pauseAfterLoadMs": 1000, | ||
| "networkQuietThresholdMs": 1000, | ||
| "cpuQuietThresholdMs": 1000, |
There was a problem hiding this comment.
why are these changing?
There was a problem hiding this comment.
We apply overrides to these default values when using DT throttling. Previously, this was applied to the values on the fake navigation object constructed during initializeConfig.
Now that the fake navigation object is removed, we have to apply the overrides to the settings object directly.
adamraine
requested review from
connorjclark
and removed request for
a team
adamraine
commented
Sep 20, 2023
| /** | ||
| * @param {LH.Gatherer.GatherMode} gatherMode | ||
| * @param {LH.Config=} config | ||
| * @param {LH.Flags=} flags | ||
| * @return {Promise<{resolvedConfig: LH.Config.ResolvedConfig, warnings: string[]}>} |
There was a problem hiding this comment.
There are no config warnings anymore but there could be in the future I guess. Shouldn't be too hard to add this if we ever want them again.
connorjclark
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config navigations were moved to internal stuff in 10.0: #13881. It was our plan to remove them completely once the legacy path had been removed completely. This PR fulfills the end goal of that plan.
From a user perspective, the only difference should be that we perform 1
about:blankjump at the start instead of 2. The rest of this is just removing technical debt.Having just one
about:blankjump makes it easy to fix #15487 as well.