Move no-old-flexbox to table formatter #1545
Conversation
ebidel
changed the title
so close :P |
| sheet.parsedContent.forEach(props => { | ||
| const formattedStyleRule = StyleHelpers.getFormattedStyleRule(sheet.content, props); | ||
|
|
||
| let url = sheet.header.sourceURL; | ||
| if (!url) { |
There was a problem hiding this comment.
I also check if it matches the pageUrl if we want to be consistent. Also thoughts on using getDisplayName here?
|
I have a fix in #1536 for the wonky indentation of the I can split out too btw |
|
caching pokemon is important for great performance |
| @@ -18,3 +18,6 @@ | |||
| body { | |||
| background-color: #eee; | |||
| } | |||
| .doesnotapply { | |||
| display: flexbox; /* FAIL */ | |||
| } | |||
| urlList.push({ | ||
| url: sheet.header.sourceURL, | ||
| label: formattedStyleRule.location, | ||
| url, |
There was a problem hiding this comment.
url: sheet.header.sourceURL || 'inline', seems a bit clearer here
There was a problem hiding this comment.
added in the url === pageUrl check above
| @@ -96,14 +96,14 @@ function getFormattedStyleRule(content, parsedContent) { | |||
| }, []).join('\n'); | |||
| } | |||
|
|
|||
| const block = ` | |||
| ${parsedContent.selector} { | |||
| const block = `\`\`\`${parsedContent.selector} { | |||
There was a problem hiding this comment.
doing this in the extendedInfo value seems a bit ugly. What about a different keyword for the table formatter that annotates code blocks with the ```s?
|
|
||
| return { | ||
| styleRule: block.trim(), | ||
| location: `line: ${startLine}, row: ${start}, col: ${end}` | ||
| startLine, | ||
| location: `${start}:${end}` |
There was a problem hiding this comment.
we should think about settling on a format for parsed source blocks at some point. ESTree has a semi-standard format (albeit for JS): https://github.com/estree/estree/blob/master/es5.md#node-objects
|
PTAL |
|
needs a rebase due to table churn |
|
rebased! |
| @@ -86,6 +86,8 @@ class Table extends Formatter { | |||
| switch (key) { | |||
| case 'code': | |||
| return '`' + value.trim() + '`'; | |||
| case 'pre': | |||
| return '\`\`\`\n' + result[key].trim() + '\`\`\`'; | |||
There was a problem hiding this comment.
add this to table-formatter-test.js?
There was a problem hiding this comment.
oh, and added to the jsdoc above :)
R: @patrickhulce all
This PR:
<pre>support to the markdown rendererno-old-flexboxaudit where it was not finding all old flexbox uses. The audit was incorrectly testing vendor prefixed css properties and matching them with prefixed values. They need to be run separately.