tests: check for console errors and warnings in pptr tests #15516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
requested review from
brendankenny
and removed request for
a team
connorjclark
commented
Oct 4, 2023
| @@ -46,6 +46,8 @@ export class ViewerUIFeatures extends ReportUIFeatures { | |||
| } | |||
|
|
|||
| this._getI18nModule().then(async (i18nModule) => { | |||
| if (!report.i18n?.icuMessagePaths) return; | |||
|
|
|||
There was a problem hiding this comment.
older LHRs were erroring, but in a non-fatal way since this is a loose promise.
I didn't prevent the loading of the i18n module because the test would need to exclude the warning Chrome emits on an unused preload directive, and this being a minor optimization for ancient LHRs I'd rather not further complicate the tests.
adamraine
reviewed
Oct 17, 2023
viewer/test/viewer-test-pptr.js
Outdated
| pageErrors = []; | ||
| // Expected errors. | ||
| const errors = await claimErrors(); | ||
| expect(errors).toHaveLength(3); |
There was a problem hiding this comment.
Are these new errors expected because of the new timeout above?
There was a problem hiding this comment.
No, they have always been printed to the console. Now the tests are checking console errors in addition to pageerror.
adamraine
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better error checking in these tests would have prevented #15515. All the pptr tests the listen for pageerror now also fail on console error/warning. There was also an issue of timing, which I resolved in this PR too w/ usage of promises and a method to "claim" the errors.