i18n: import #15520
Closed
i18n: import #15520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
requested review from
brendankenny
and removed request for
a team
adamraine
approved these changes
Oct 5, 2023
paulirish
reviewed
Oct 5, 2023
| @@ -1038,7 +1038,7 @@ | |||
| "message": "La URL del manifiesto cambió mientras este se estaba recuperando." | |||
| }, | |||
| "core/audits/installable-manifest.js | manifest-missing-name-or-short-name": { | |||
| "message": "El manifiesto no contiene los campos \"name\" ni \"short_name\"" | |||
There was a problem hiding this comment.
ah we JUST changed this so we probably are doing an import a tad too quickly?
There was a problem hiding this comment.
We could defer updating strings for today's release - or I could spend some time building a way to opt out of specified i18n strings manually for cases like this.
There was a problem hiding this comment.
I'm fine to defer the release for another day to ensure we get the translated versions. In the future, maybe we should build in a 1-2 day buffer between string export and string import before release?
There was a problem hiding this comment.
We also need more regular strings import. Want to help by setting up the cron job on your internal machine?
Merged
Merged
|
Closing in favor of #15579 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.