Viewer: add PWA images. #1554
Merged
Viewer: add PWA images. #1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebidel
suggested changes
Jan 27, 2017
| @@ -0,0 +1,18 @@ | |||
| { | |||
| <link rel="icon" type="image/png" href="images/favicon-32x32.png" sizes="32x32"> | ||
| <link rel="icon" type="image/png" href="images/favicon-16x16.png" sizes="16x16"> | ||
| <link rel="manifest" href="images/manifest.json"> | ||
| <link rel="mask-icon" href="images/safari-pinned-tab.svg" color="#304ffe"> |
There was a problem hiding this comment.
My personal feeling is that we should't support anything that's not the web app manifest. Everything is legacy at this point and more stuff for us to maintain.
Curious on what others think.
|
@ebidel: done. I also changed the previous favicon with a newly generated one so that colors are the same. |
XhmikosR
changed the title
|
Good stuff. Thanks. |
ebidel
approved these changes
Jan 28, 2017
|
@ebidel: don't forget to update the gh-pages branch. |
|
It'll get pushed on the next release. Hopefully next week. cc @brendankenny |
|
I see. I thought you updated the gh-pages branch when there were changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1506