Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(lantern): refactor fcp graph method signatures #15572

Merged
merged 6 commits into from
Dec 8, 2023
Merged

core(lantern): refactor fcp graph method signatures #15572

merged 6 commits into from
Dec 8, 2023

Conversation

paulirish
Copy link
Member

This is minor stuff. Just some changes that I think improve readability.

@paulirish paulirish requested a review from a team as a code owner October 26, 2023 21:52
@paulirish paulirish requested review from connorjclark and removed request for a team October 26, 2023 21:52
connorjclark
connorjclark approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@connorjclark connorjclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good refactor 👍

@connorjclark
Copy link
Collaborator

Did you expect this refactor to modify lantern results?

@paulirish
Copy link
Member Author

paulirish commented Dec 8, 2023 •
edited
Loading

Did you expect this refactor to modify lantern results?

wow no.

but its probably due to these changes: https://github.com/GoogleChrome/lighthouse/pull/15572/files#diff-8604cd7cfa4aa1569f242604006f70209845d219da08e0ecc38f36a31c573223R36-R41

was trying to fix the readability.. didnt expect to affect results.. but clearly i messed up

@paulirish
Copy link
Member Author

Did you expect this refactor to modify lantern results?

accidental paste: c25c95d#diff-04026f595f6b57b230aca16e561ba805ece6d979151ff8971dfd509bf3a9bc6aR55

So happy for tests. :)

@connorjclark connorjclark merged commit ae8db74 into main Dec 8, 2023
29 checks passed
@connorjclark connorjclark deleted the magic-obj-for-getFirstPaintBasedGraph branch December 8, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connorjclark connorjclark connorjclark approved these changes

Assignees

@connorjclark connorjclark

Labels
waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paulirish @connorjclark @devtools-bot