-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter out goog_ user timings. #1563
Conversation
return ['goog_']; | ||
} | ||
|
||
static excludeBlacklisted(timing) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jsdoc would be good (nit: and maybe comment above should actually go on this function)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
k done
9b44a42
to
7181b1b
Compare
/** | ||
* We remove mark/measures entered by third parties not of interest to the user | ||
* @param {!UserTimingsExtendedInfo} artifacts | ||
* @return {boolean>} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stray >
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
7181b1b
to
e842b57
Compare
needs a rebase now :) |
* @return {boolean} | ||
*/ | ||
static excludeBlacklisted(timing) { | ||
return UserTimings.blacklistedPrefixes.every(prefix => !timing.name.startsWith(prefix)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's that Node > 4 bling ✨
Conflicts resolved. Merging! |
Fixes #1548