misc: improve download-chrome.sh usability #15646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
changed the title
connorjclark
changed the title
connorjclark
force-pushed
the
better-download-chrome
branch
from
5dc949e
to
cf2795c
Compare
paulirish
approved these changes
Nov 30, 2023
| curl "$url" -Lo chrome.zip && unzip -q chrome.zip | ||
| fi | ||
| mkdir -p .tmp-download && cd .tmp-download | ||
| curl "$url" -Lo chrome.zip && unzip -q chrome.zip && rm chrome.zip |
There was a problem hiding this comment.
i'd probably just put all these on their own lines
conceivably the -e is equivalent to stringing everything with && but i'm sure there's some idiosyncracies that I don't care about. but.. its probably close enough
also no big whoop. i'm fine with &&'s too.
There was a problem hiding this comment.
idk why i bothered doing it this way when I normally don't, but fwiw the reason was structural/semantics, dealing with each like thing one line at a time.... little silly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script wasn't very simple to use locally, and it was more complex than it needed to be for CI. should be better now.