Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(emulation): bump chrome UA to m119 #15661

Merged
merged 2 commits into from
Dec 5, 2023
Merged

core(emulation): bump chrome UA to m119 #15661

merged 2 commits into from
Dec 5, 2023

Conversation

paulirish
Copy link
Member

standard UA version bump.

but i also tweaked that "difference found" error text to log out what the difference was...

image

@paulirish paulirish requested a review from a team as a code owner December 5, 2023 21:10
@paulirish paulirish requested review from connorjclark and removed request for a team December 5, 2023 21:10
Copy link
Member

@adamraine adamraine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

Doesn't need to happen in this PR, but WDYT about making this version bump an automated part of the release process. Could maybe do that here: https://github.com/GoogleChrome/lighthouse/blob/main/core/scripts/release/bump-versions.js?

@paulirish
Copy link
Member Author

but WDYT about making this version bump an automated part of the release process.

clever idea. sounds great.

@devtools-bot devtools-bot merged commit 4e09806 into main Dec 5, 2023
27 of 29 checks passed
@devtools-bot devtools-bot deleted the bump119 branch December 5, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants