Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report: fix sticky table if no sticky header #15666

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

adamraine
Copy link
Member

@adamraine adamraine commented Dec 6, 2023

Fixes report bug when sticky header is missing:

Screenshot 2023-12-06 at 2 49 02 PM

Repro: generate a report with 1 category

@adamraine adamraine requested a review from a team as a code owner December 6, 2023 22:51
@adamraine adamraine requested review from connorjclark and removed request for a team December 6, 2023 22:51
Copy link
Collaborator

@connorjclark connorjclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

did you verify all is good (w/ one category, and with all) w/ yarn open-devtools?

@adamraine
Copy link
Member Author

did you verify all is good (w/ one category, and with all) w/ yarn open-devtools?

yup

@adamraine adamraine merged commit 25430b8 into main Dec 6, 2023
29 checks passed
@adamraine adamraine deleted the sticky-header-fix branch December 6, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants