core(trace-elements): remove element score field #15677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
changed the title
adamraine
changed the title
adamraine
force-pushed
the
trace-els-rm-score
branch
from
3cacae3
to
3b9548c
Compare
connorjclark
reviewed
Dec 8, 2023
| {nodeId: 13, score: 0.1}, | ||
| {nodeId: 14, score: 0.1}, | ||
| {nodeId: 15, score: 0.1}, | ||
| {nodeId: 3}, // score: 1.0 |
There was a problem hiding this comment.
did you mean to keep?
There was a problem hiding this comment.
No, score isn't on the trace elements anymore. This was just a way for the test to justify the order given.
connorjclark
reviewed
Dec 8, 2023
| @@ -43,12 +43,12 @@ class LayoutShiftElements extends Audit { | |||
| const {cumulativeLayoutShift: clsSavings, impactByNodeId} = | |||
| await CumulativeLayoutShiftComputed.request(artifacts.traces[Audit.DEFAULT_PASS], context); | |||
|
|
|||
| /** @type {Array<{node: LH.Audit.Details.ItemValue, score?: number}>} */ | |||
| /** @type {Array<{node: LH.Audit.Details.ItemValue, score: number}>} */ | |||
There was a problem hiding this comment.
does this refactor mean the impactByNodeId map should always have a value, and so || 0 was done to placate typescript? or are we setting 0 where before it would be undefined?
There was a problem hiding this comment.
It's kinda both. Every LS element that appears in TraceElements should also appear in impactByNodeId. I'm not aware of any situation where the || 0 would get triggered, but if it does the previous behavior would have been to leave as undefined.
connorjclark
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #15593
With
impactByNodeIdon the CLS computed artifact, we don't need the trace elementsscorefield anymore.