core(layout-shift-elements): hide audit #15730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you create an issue for 12.0 to remind us to handle this. |
adamraine
reviewed
Jan 4, 2024
| @@ -258,6 +258,7 @@ Array [ | |||
| "largest-contentful-paint", | |||
| "largest-contentful-paint-element", | |||
| "layout-shift-elements", | |||
| "layout-shifts", | |||
There was a problem hiding this comment.
Why is this just appearing now? Wouldn't this have been done in the previous PR?
There was a problem hiding this comment.
uh... no idea. It's otherwise passing in another PR w/ latest changes. https://github.com/GoogleChrome/lighthouse/actions/runs/7416263035/job/20180926303?pr=15731#step:12:4250
There was a problem hiding this comment.
but it fails locally for me on main.
There was a problem hiding this comment.
So looks like API test is failing on main for me locally. Seems like something weird is going on in CI so this PR LGTM
connorjclark
force-pushed
the
hide-layout-shift-elements
branch
from
6123b75
to
0ff259d
Compare
adamraine
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This audit has been replaced by
layout-shifts#15703Hide it, and we'll likely remove it for 12.0