core: warning banner for PWA category deprecation #15741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
reviewed
Jan 10, 2024
report/renderer/report-utils.js
Outdated
| @@ -476,6 +476,9 @@ const UIStrings = { | |||
| openInANewTabTooltip: 'Open in a new tab', | |||
| /** Generic category name for all resources that could not be attributed to a 1st or 3rd party entity. */ | |||
| unattributable: 'Unattributable', | |||
|
|
|||
| /** Message communicating the removal of the PWA category. */ | |||
| pwaRemovalMessage: 'Lighthouse will be deprecating the PWA category with Lighthouse version 12.0. More information about its deprecation [here](https://developer.chrome.com/blog/update-install-criteria?hl=en). For recommended PWA testing, refer to the documentation [here](https://developer.chrome.com/docs/devtools/progressive-web-apps/).', | |||
There was a problem hiding this comment.
re https://developer.chrome.com/blog/update-install-criteria?hl=en
@connorjclark @brendankenny can we just leave hl=en in for translators. Will they change this link to use their own locale?
There was a problem hiding this comment.
ah this was an artifact of copying/pasting.. i can remove the ?hl=en :)
There was a problem hiding this comment.
They will not change that.
Do we cover the same languages? We could add this programatically.
There was a problem hiding this comment.
Looks like they don't cover every language we do. Let's just remove the ?hl=en, maybe the site can automatically detect locale.
adamraine
reviewed
Jan 11, 2024
adamraine
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://lighthouse-pwhq5k0h5-googlechrome.vercel.app/gh-pages/viewer/?gist=dfb70105a0eefd64866be4271423eaab