Add 2 test cases for URL blocking #1577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
reviewed
Jan 30, 2017
| @@ -222,6 +225,28 @@ describe('GatherRunner', function() { | |||
| }); | |||
| }); | |||
|
|
|||
| it('tells the driver to block given URL patterns when blockedUrlPatterns is given', () => { | |||
| const receivedUrlPatterns = []; | |||
| const urlPatterns = ['http://*.evil.com', '.jpg', '.woff2']; | |||
There was a problem hiding this comment.
".jpg" is equivalent to ".jpg" ?? if so, i didn't know that. :)
There was a problem hiding this comment.
Yes. They are the same. I was also surprised.
| }); | ||
|
|
||
| return GatherRunner.setupDriver(driver, {flags: {blockedUrlPatterns: urlPatterns.slice()}}) | ||
| .then(() => assert.equal(receivedUrlPatterns.sort().join(), urlPatterns.sort().join())); |
There was a problem hiding this comment.
not sure if assert.equal means much on these arrays. do we need deepEqual or deepStrictEqual ? /me shrugs.
There was a problem hiding this comment.
I'm not comparing arrays here. I sort them and join the elements as a string respectively, then compare the strings. But yeah, deepStrictEqual seems better. Thx for your advice.
paulirish
approved these changes
Jan 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure adding blocked URL patterns works correctly.