core(lantern): move NetworkRequest to lib/dependency-graph #15842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
force-pushed
the
mv-network-request
branch
from
5f77645
to
77b6952
Compare
connorjclark
force-pushed
the
mv-network-request
branch
from
77b6952
to
00de512
Compare
connorjclark
force-pushed
the
mv-network-request
branch
from
00de512
to
d82a880
Compare
adamraine
reviewed
Feb 29, 2024
| @@ -4,13 +4,12 @@ | |||
| * SPDX-License-Identifier: Apache-2.0 | |||
| */ | |||
|
|
|||
| import * as LH from '../../../types/lh.js'; | |||
adamraine
reviewed
Feb 29, 2024
| @@ -5,6 +5,7 @@ | |||
| */ | |||
|
|
|||
| import * as LH from '../../../../types/lh.js'; | |||
| import {NetworkRequest} from '../network-request.js'; | |||
There was a problem hiding this comment.
Would /** @typedef {import('../network-request.js').NetworkRequest} NetworkRequest */ also work? I would prefer that to getting all these "unused" imports and then ignoring the eslint rule.
LH only needed a physical import because LH is a module and jsdoc doesn't support that (yet). NetworkRequest is an actual type that we can assign using jsdoc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #15841
NetworkRequest is used to model the network inside the Lantern graph and simulator. Instead of attempting to recreate a very similar interface that continues to meet the needs of all our use cases in Lighthouse, let's just move the entire NetworkRequest to lantern. Consumers of the library will need to create these on their own to make a graph, and how they do that (CDT logs or trace) is irrelevant.
We may possibly revisit the network interface in Lantern down the line.