Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(types): add missing fields to Result.Category and NodeDetails #16006

Merged
merged 3 commits into from
May 21, 2024
Merged

core(types): add missing fields to Result.Category and NodeDetails #16006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e7de63
add supportedModes to Result.Category
angad-sethi May 20, 2024
e20540c
add explanantion type on NodeDetails
angad-sethi May 20, 2024
520707f
empty to rerun cla check
angad-sethi May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions types/artifacts.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ declare module Artifacts {
boundingRect: Rect,
snippet: string,
nodeLabel: string,
explanation?: string,
}

interface RuleExecutionError {
Expand Down
2 changes: 2 additions & 0 deletions types/lhr/lhr.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ declare module Result {
score: number|null;
/** An array of references to all the audit members of this category. */
auditRefs: AuditRef[];
/** An array of all the modes supported by the category. */
supportedModes?: Result.GatherMode[];
}

interface AuditRef {
Expand Down
Loading