core(lantern): resolve some differences when using trace #16033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
Jun 4, 2024
| @@ -18,7 +18,6 @@ const NON_NETWORK_SCHEMES = [ | |||
| ]; | |||
|
|
|||
| /** | |||
| * Use `NetworkRequest.isNonNetworkRequest(req)` if working with a request. | |||
There was a problem hiding this comment.
drive by, stale comment
connorjclark
commented
Jun 4, 2024
| @@ -131,7 +126,7 @@ describe('Byte efficiency base audit', () => { | |||
| }, simulator, metricComputationInput, {computedCache: new Map()}); | |||
|
|
|||
| assert.equal(result.metricSavings.FCP, 900); | |||
| assert.equal(result.metricSavings.LCP, 1350); | |||
| assert.equal(result.metricSavings.LCP, 900); | |||
| }); | |||
There was a problem hiding this comment.
the results changed here b/c createTestTrace is now always producing network events (not just when the env variable is true), so in the graph there is now a new dependency added from a network node to CPU node, cuz of the new ResourceSendRequest event (added in createTestTrace) linking the two (linkCPUNodes)
adamraine
approved these changes
Jun 4, 2024
| redirectedRequest.url = redirect.url; | ||
| redirectedRequest.parsedURL = this._createParsedUrl(redirect.url); | ||
| // TODO: TraceEngine is not retaining the actual status code. | ||
| redirectedRequest.statusCode = 302; | ||
| redirectedRequest.resourceType = undefined; | ||
| // TODO: TraceEngine is not retaining transfer size of redirected request. | ||
| redirectedRequest.transferSize = 400; |
There was a problem hiding this comment.
Is this always the transfer size of a redirect?
There was a problem hiding this comment.
No, that depends on the headers sent. 400 is just exactly the size of a trace I was debugging. But otherwise it would be the size of the final response and so this avoids an overestimate for the time being.
connorjclark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node.recordinstead ofnode.requestref #15841