Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(lantern): remove devtools log from tests #16050

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented Jun 7, 2024

ref #15841

Removes all the devtools log from core/tests/lantern, which at this point was only being used to derive a URL.

@connorjclark connorjclark requested a review from a team as a code owner June 7, 2024 22:17
@connorjclark connorjclark requested review from adamraine and removed request for a team June 7, 2024 22:17
@@ -971,8 +971,24 @@ class PageDependencyGraph {
// above.
lanternRequests.sort((a, b) => a.rendererStartTime - b.rendererStartTime);

// URL defines the initial request that the Lantern graph starts at (the root node) and the
// main document request. These are equal if there are no redirects.
Copy link
Collaborator Author

@connorjclark connorjclark Jun 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will eventually figure out how to derive these two urls from the trace and remove URL as a param.

right now the fallback code here is not smart enough to detect client redirects (b/c that is not represented in our network model), so it is up to the caller to pass in the right urls

@connorjclark connorjclark changed the title core(lantern): extract main thread events without LH TraceProcessor tests(lantern): remove devtools log from tests Jun 7, 2024
Base automatically changed from lantern-no-trace-processor to main June 10, 2024 19:03
@connorjclark connorjclark merged commit f8063f8 into main Jun 10, 2024
27 checks passed
@connorjclark connorjclark deleted the lantern-test-rm-dt-logs branch June 10, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants