Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(lantern): use TraceEngine directly in test fixtures #16057

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

connorjclark
Copy link
Collaborator

ref #15841

Removes usage the ComputedArtifact version of TraceEngineResult of LH computed artifact from lantern unit tests.

also, driveby change where TraceEngineResult now runs all the handlers (gotta do it at some point, and I wanted the types to match in this PR)

@connorjclark connorjclark requested a review from a team as a code owner June 10, 2024 22:27
@connorjclark connorjclark requested review from adamraine and removed request for a team June 10, 2024 22:27
@connorjclark connorjclark merged commit 32cafcb into main Jun 11, 2024
27 checks passed
@connorjclark connorjclark deleted the lantern-test-rm-computed branch June 11, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants