tests(lantern): remove Speedline from Lantern unit test for now #16060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
reviewed
Jun 10, 2024
| const data = await getComputationDataFromFixture({trace}); | ||
| // TODO: observedSpeedIndex is from the Speedline library, and is used for optimistic | ||
| // mode. At the moment callers must pass the result into Lantern. |
There was a problem hiding this comment.
nit: what is the TODO here? Eventually move speedline inside the lantern library if we need it?
adamraine
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #15841
Lantern expects to be given the result of running Speedline to determine SpeedIndex w/
optimisticmode. Ideally Lantern calls that library itself, but currently left to callers. Since there is no plan I'm aware of to include SpeedIndex in RPP, for now we can defer moving/using Speedline inside Lantern since only Lighthouse needs it. saves some work.