correct debugString if no manifest short_name found #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
reviewed
Feb 2, 2017
| // Historically, Chrome recommended 12 chars as the maximum length to prevent truncation. | ||
| // See #69 for more discussion. | ||
| // https://developer.chrome.com/apps/manifest/name#short_name | ||
| const manifestValue = manifest.short_name.value || manifest.name.value || ''; | ||
| isShortNameShortEnough = manifestValue && manifestValue.length <= suggestedLength; | ||
| isShortNameShortEnough = shortNameValue && shortNameValue.length <= suggestedLength; |
There was a problem hiding this comment.
nit: don't need the definedness check now
ebidel
approved these changes
Feb 2, 2017
brendankenny
force-pushed
the
shortname
branch
from
9ac90dc
to
dd6fbc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1616