Fix viewer's "Export -> Save as..." with Firefox. #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only thing I wonder is if we should call |
|
I added a new patch which also removes the node from DOM and changes the |
ebidel
suggested changes
Feb 3, 2017
| @@ -361,9 +361,12 @@ class LighthouseViewerReport extends LighthouseReport { | |||
| const a = document.createElement('a'); | |||
| a.download = `${filename}${ext}`; | |||
| a.href = URL.createObjectURL(blob); | |||
| document.body.appendChild(a); | |||
There was a problem hiding this comment.
document.body.appendChild(a); // Firefox requires anchor be in the DOM.
| setTimeout(_ => URL.revokeObjectURL(a.href), 500); // cleanup. | ||
| // cleanup. | ||
| document.body.removeChild(a); | ||
| setTimeout(_ => URL.revokeObjectURL(a.href), 0); |
There was a problem hiding this comment.
We may want to keep the 500ms delay just to be on the safe side.
|
@ebidel: done. I kept the interval to 500, even though it seems unneeded from my tests. |
For some weird reason, Firefox needs `document.body.appendChild(a)` too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some weird reason, Firefox needs
document.body.appendChild(a)too.Fixes #1574.