fMP: Use last fMPCandidate if no FMP is marked. #1632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
reviewed
Feb 3, 2017
| if (candidates.length === 0) { | ||
| throw new Error('No usable `firstMeaningfulPaint(Candidate)` events found in trace'); | ||
| } | ||
| tabTrace.firstMeaningfulPaintEvt = candidates.pop(); |
There was a problem hiding this comment.
do you think any other audits would need to use this inferred fmp event? or is this it?
| @@ -148,7 +148,7 @@ class Metrics { | |||
| * @param {number} navStartTs | |||
| const navStartTs = metrics.find(e => e.id === 'navstart').ts; | ||
| if (this.getNavigationStartEvt().ts !== navStartTs) { | ||
| const navStartEvt = metrics.find(e => e.id === 'navstart'); | ||
| if (!navStartEvt || this.getNavigationStartEvt().ts !== navStartEvt.ts) { |
There was a problem hiding this comment.
does this.getNavigationStartEvt() always find something or is this another candidate for TypeError too?
There was a problem hiding this comment.
yup it should always find something.
The getNavigationStartEvt method could live on top of trace-of-tab as well, though...
There was a problem hiding this comment.
^ filed that over here #1568
paulirish
force-pushed
the
missing-fmp
branch
from
9cafae6
to
9e6bc39
Compare
|
PTAL |
brendankenny
reviewed
Feb 4, 2017
| log.verbose('trace-of-tab', `No firstMeaningfulPaint found, falling back to last ${fmpCand}`); | ||
| const lastCandidate = frameEvents.filter(e => e.name === fmpCand).pop(); | ||
| if (!lastCandidate) { | ||
| log.verbose('No `firstMeaningfulPaintCandidate` events found in trace'); |
There was a problem hiding this comment.
'trace-of-tab' for log title?
|
Travis is confused, but the tests are in good shape. :) |
patrickhulce
approved these changes
Feb 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good test page for this is https://madeby.google.com/phone/ which we always time out after 30s
fixes #1564
--
fmpCandidate comes from
loadingtrace category (for whatever reason).The changes in pwmetrics are for handling -1 failures a little better.