Use default args now that node 6 is required. #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
maybe we should do one big pass for places where we can drop the || dance and use default parameters? A quick search didn't turn up that many, but enough that a PR for each is going to get pretty noisy :) |
|
Agreed, but I just looked for node comments and saw this one and the |
|
@brendankenny: please check now. I enabled ESLint's |
XhmikosR
changed the title
|
@XhmikosR I fixed the merge conflict in the github UI and immediately regretted it :) Do you want to back that out, fix the merge conflict and I can land? |
brendankenny
approved these changes
Feb 7, 2017
|
@brendankenny: rebased, check now. |
|
thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's also
polyfillNode4Supportwhich I can't quite look into now. If the name is wrong, the function should be renamed otherwise cleaned up.