Update --perf config to latest #1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebidel
reviewed
Feb 6, 2017
lighthouse-core/config/perf.json
Outdated
| "critical-request-chains", | ||
| "unused-css-rules", | ||
| "dobetterweb/uses-optimized-images", | ||
| "dobetterweb/uses-responsive-images" |
There was a problem hiding this comment.
should we add these audits as well:
links-blocking-first-paint
scripts-blocking-first-paint
|
PTAL Reports look like this:
|
brendankenny
approved these changes
Feb 6, 2017
| }], | ||
| "gatherers": [ | ||
| "url", | ||
| "image-usage", |
There was a problem hiding this comment.
doesn't look like it will matter, but any reason to include these in the first pass instead of the second?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
once we have tags in the default config (#1463), we can swap to that and won't have it fall behind again.
but until then..