Reformat the critical chain output #1647
Conversation
| @@ -89,7 +95,8 @@ | |||
| <span class="cnc-node__tree-hostname">({{ this.hostname }})</span> | |||
| {{/parseURL}} | |||
| {{#unless hasChildren}} | |||
| - <span class="cnc-node__chain-duration">{{chainDuration startTime this.node.request.endTime }}ms, {{formatTransferSize this.transferSize}}KB</span> | |||
| - <span class="cnc-node__chain-duration">{{chainDuration startTime this.node.request.endTime }}ms</span>, | |||
| <span class="cnc-node__chain-duration">{{formatTransferSize this.transferSize}}KB</span> | |||
There was a problem hiding this comment.
nit: not really chain-duration, why was it split into two spans? or maybe use a new chain-size modified or something?
There was a problem hiding this comment.
split into two so that the comma wasn't bolded. and yah im lazily not adjusting the classname. i could.
There was a problem hiding this comment.
gotcha, nah not a big deal
| longestChainDuration = duration; | ||
| if (duration > longest.duration) { | ||
| longest.duration = duration; | ||
| longest.transferSize = opts.chainTransferSize; |
There was a problem hiding this comment.
this was outstanding, but why does this chainTransferSize not include the size of the file that pushed the chain out farthest? the duration is pulled from the youtube base.js in the screenshot which is ~430kb and larger than the entire chain size of ~390kb
There was a problem hiding this comment.
good question. mind if i break this into a separate issue?
| ` - Longest chain duration (shorter is better): ${longestDuration}ms\n` + | ||
| ` - Longest chain transfer size (smaller is better): ${longestTransferSize}KB\n` + | ||
| const output = ` - Longest request chain: ${longestDuration}ms` + | ||
| ` over ${longestChain } requests, totalling ${longestTransferSize}KB\n` + |
There was a problem hiding this comment.
nit extra spacing: ${longestChain}
| @@ -55,6 +55,12 @@ | |||
| color: #999; | |||
| } | |||
|
|
|||
| .initial-nav { | |||
There was a problem hiding this comment.
we'll need to add this to the .css file when #1652 lands.
paulirish
force-pushed
the
critchainreformat
branch
from
7483d1a
to
3499f59
Compare
Some upgrades to this little guy to make it more concise.
details/summaryso its not too loud in the reportScreenshots: