fix: table formatter image preview URL encode #1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
upstream issue: markedjs/marked#619 (looks like it won't be fixed) |
ebidel
approved these changes
Feb 10, 2017
|
FWIW in defense of marked I think it's actually an artifact of the markdown spec itself. There's no guarantee in an arbitrary link that an opening paren will be followed by a close paren. Also relevant http://meta.stackexchange.com/questions/13501/links-to-urls-containing-parentheses |
|
🚫 🖼 |
"spec" :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @ebidel all
Image previews were broken for URLs with
)since markdown can't handle themBefore
After
