Geolocation audit: warn if page is non-secure origin #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebidel
commented
Feb 10, 2017
| throw new Error('Unable to determine if this permission was requested on page load ' + | ||
| 'because it had already been set. Try resetting the permission and running ' + | ||
| 'Lighthouse again.'); | ||
| return options.driver.evaluateAsync('(function(){return window.isSecureContext;})()') |
There was a problem hiding this comment.
Note: isSecureContext returns true for https:// and http://localhost. The latter is a secure context for testing purposes. We may want to consider moving the HTTPs gatherer to this or supplementing it with this check for #1175.
| .then(permissionState => { | ||
| if (permissionState === 'granted' || permissionState === 'denied') { | ||
| throw new Error('Unable to determine if the Geolocation permission was ' + | ||
| 'requested on page load because it was already granted/denied. ' + |
There was a problem hiding this comment.
since we have the permissionState and we know it was either "granted" or "denied", should we just inject it into the string instead of saying "granted/denied"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: all
Fixes #1676