Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS consistency changes. #1698

Merged
merged 1 commit into from
Feb 15, 2017
Merged

CSS consistency changes. #1698

merged 1 commit into from
Feb 15, 2017

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Feb 11, 2017 •
edited
Loading

  • use numeric values for font-weight
  • stop using shorthands when one property is meant to change (background, list-style)
  • use hex color values instead of rgb or color names when they are shorter
  • use outline: none instead of zero
  • remove duplicate property border-radius
  • fix typo in comment
  • minor HTML consistency changes

@paulirish
Copy link
Member

Do you have tooling that can help maintain this? I'm afraid it's going to be easy to regress these. :/

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Feb 11, 2017 •
edited
Loading

Unfortunately all the CSS tweaks I've done so far are made manually.

We could look into stylelint or something. But these changes are mostly cosmetic apart from not using shorthands. And smaller size :)

@XhmikosR
Copy link
Contributor Author

Fixed one more issue, a duplicate border-radius property.

@XhmikosR
Copy link
Contributor Author

So any new thoughts about this? Things I should revert or add?

@ebidel
Copy link
Contributor

ebidel commented Feb 15, 2017 •
edited
Loading

Agreed with Paul on the long-term maintenance of this stuff with out tools. That sad, this is low key. Can you rebase?

@XhmikosR
CSS consistency changes.
8cb2216 
* use numeric values for `font-weight`
* stop using shorthands when one property is meant to change (`background`, `list-style`)
* use hex color values instead of rgb or color names when they are shorter
* use `outline: none` instead of zero
* remove duplicate property `border-radius`
* fix typo in comment
* minor HTML consistency changes
@XhmikosR
Copy link
Contributor Author

Done. I still don't get those random AppVeyor failures to kill the running instance but they seem to happen a lot.

@ebidel ebidel merged commit f364e61 into GoogleChrome:master Feb 15, 2017
@XhmikosR XhmikosR deleted the css-tweaks branch February 15, 2017 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebidel ebidel ebidel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@XhmikosR @paulirish @ebidel