Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move perfy stuff into Perf Diagnostics report aggregation. #1724

Merged
merged 3 commits into from
Feb 24, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lighthouse-core/audits/byte-efficiency/unused-css-rules.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class UnusedCSSRules extends Audit {
return {
category: 'CSS',
name: 'unused-css-rules',
description: 'Avoids loading unnecessary CSS',
description: 'Unused CSS rules',
helpText: 'Remove unused rules from stylesheets to reduce unnecessary ' +
'bytes consumed by network activity. ' +
'[Learn more](https://developers.google.com/speed/docs/insights/OptimizeCSSDelivery)',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class UsesOptimizedImages extends Audit {
return {
category: 'Images',
name: 'uses-optimized-images',
description: 'Avoids unoptimized images',
description: 'Unoptimized images',
helpText: 'Images should be optimized to save network bytes. ' +
'The following images could have smaller file sizes when compressed with ' +
'[WebP](https://developers.google.com/speed/webp/) or JPEG at 80 quality. ' +
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class UsesResponsiveImages extends Audit {
return {
category: 'Images',
name: 'uses-responsive-images',
description: 'Avoids oversized images',
description: 'Oversized Images',
helpText:
'Image sizes served should be based on the device display size to save network bytes. ' +
'Learn more about [responsive images](https://developers.google.com/web/fundamentals/design-and-ui/media/images) ' +
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class LinkBlockingFirstPaintAudit extends Audit {
return {
category: 'Performance',
name: 'link-blocking-first-paint',
description: 'Avoids `<link>` that delay first paint',
description: 'Render-blocking Stylesheets',
helpText: 'Link elements are blocking the first paint of your page. Consider ' +
'inlining critical links and deferring non-critical ones. ' +
'[Learn more](https://developers.google.com/web/tools/lighthouse/audits/blocking-resources).',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class ScriptBlockingFirstPaint extends Audit {
return {
category: 'Performance',
name: 'script-blocking-first-paint',
description: 'Avoids `<script>` in head that delay first paint',
description: 'Render-blocking scripts',
helpText: 'Script elements are blocking the first paint of your page. Consider inlining ' +
'critical scripts and deferring non-critical ones. ' +
'[Learn more](https://developers.google.com/web/tools/lighthouse/audits/blocking-resources).',
Expand Down
50 changes: 23 additions & 27 deletions lighthouse-core/config/default.json
Original file line number Diff line number Diff line change
Expand Up @@ -279,22 +279,6 @@
"weight": 1
}
}
}, {
"name": "Using bytes efficiently",
"audits": {
"unused-css-rules": {
"expectedValue": true,
"weight": 1
},
"uses-optimized-images": {
"expectedValue": true,
"weight": 1
},
"uses-responsive-images": {
"expectedValue": true,
"weight": 1
}
}
}, {
"name": "Using modern CSS features",
"audits": {
Expand Down Expand Up @@ -322,14 +306,6 @@
"expectedValue": true,
"weight": 1
},
"link-blocking-first-paint": {
"expectedValue": true,
"weight": 1
},
"script-blocking-first-paint": {
"expectedValue": true,
"weight": 1
},
"external-anchors-use-rel-noopener": {
"expectedValue": true,
"weight": 1
Expand Down Expand Up @@ -401,20 +377,40 @@
}
}]
}, {
"name": "Performance Metrics",
"name": "Performance",
"description": "These encapsulate your app's performance.",
"scored": false,
"categorizable": false,
"items": [{
"audits": {
"dom-size": {
"expectedValue": 100,
"unused-css-rules": {
"expectedValue": true,
"weight": 1
},
"uses-optimized-images": {
"expectedValue": true,
"weight": 1
},
"uses-responsive-images": {
"expectedValue": true,
"weight": 1
},
"critical-request-chains": {
"expectedValue": true,
"weight": 1
},
"link-blocking-first-paint": {
"expectedValue": true,
"weight": 1
},
"script-blocking-first-paint": {
"expectedValue": true,
"weight": 1
},
"dom-size": {
"expectedValue": 100,
"weight": 1
},
"user-timings": {
"expectedValue": true,
"weight": 1
Expand Down
51 changes: 38 additions & 13 deletions lighthouse-core/config/perf.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"gatherers": [
"url",
"image-usage",
"content-width"
"content-width",
"dobetterweb/domstats"
]
},
{
Expand All @@ -31,18 +32,17 @@
"byte-efficiency/unused-css-rules",
"byte-efficiency/uses-optimized-images",
"byte-efficiency/uses-responsive-images",
"dobetterweb/dom-size",
"dobetterweb/link-blocking-first-paint",
"dobetterweb/script-blocking-first-paint"
],

"aggregations": [{
"name": "Perf metrics",
"name": "Performance metrics",
"description": "",
"scored": true,
"categorizable": true,
"scored": false,
"categorizable": false,
"items": [{
"name": "Page load performance is fast",
"description": "",
"audits": {
"first-meaningful-paint": {
"expectedValue": 100,
Expand All @@ -69,13 +69,38 @@
"categorizable": false,
"items": [{
"audits": {
"unused-css-rules": {},
"uses-optimized-images": {},
"uses-responsive-images": {},
"critical-request-chains": {},
"link-blocking-first-paint": {},
"script-blocking-first-paint": {},
"user-timings": {}
"unused-css-rules": {
"expectedValue": true,
"weight": 1
},
"uses-optimized-images": {
"expectedValue": true,
"weight": 1
},
"uses-responsive-images": {
"expectedValue": true,
"weight": 1
},
"critical-request-chains": {
"expectedValue": true,
"weight": 1
},
"link-blocking-first-paint": {
"expectedValue": true,
"weight": 1
},
"script-blocking-first-paint": {
"expectedValue": true,
"weight": 1
},
"dom-size": {
"expectedValue": 100,
"weight": 1
},
"user-timings": {
"expectedValue": true,
"weight": 1
}
}
}]
}]
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/formatters/partials/table.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

{{#if rows}}
<details class="subitem__details">
<summary class="subitem__detail">More information</summary>
<summary class="subitem__detail">View details</summary>
<table class="table_list {{#ifNotEq headings.length 2}}multicolumn{{/ifNotEq}}">
<thead>
<tr>
Expand Down