fix: clean up table styling #1726
Conversation
| @@ -111,6 +111,20 @@ class ReportGenerator { | |||
| } | |||
| }); | |||
|
|
|||
| Handlebars.registerHelper('kebabCase', function(str) { | |||
There was a problem hiding this comment.
would love to rebase against #1660 and add tests here
| {{/each}} | ||
| </tr> | ||
| </thead> | ||
| <tbody> | ||
| {{#each rows}} | ||
| <tr> | ||
| {{#each cols}} | ||
| <td>{{ sanitize this}}</td> | ||
| <td class="table-column table-column-{{ kebabCase (lookup ../../headingKeys @index) }}">{{ sanitize this}}</td> |
There was a problem hiding this comment.
don't like this, but not sure it's worth restructuring the format of rows just for class names here
There was a problem hiding this comment.
Nice. It's useful to be able to target these. It's hard that we have a generic table, but specific data that might need to look different here/there.
| } | ||
| .table_list .table-column.table-column-url { | ||
| text-align: left; | ||
| width: 250px; |
There was a problem hiding this comment.
could add more here, but on smaller screen sizes the optimized images table starts getting pretty squished, min-width doesn't seem to have an impact on fixed table width
|
This LGTM. One thing I notice is the
vs before:
|
patrickhulce
force-pushed
the
table_css_cleanup
branch
from
10fb615
to
ca971f8
Compare
|
oh thanks good catch @ebidel, fixed |
|
LGTM |
R: @paulirish all
Before
After
