feat: configurable blank page options #1732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebidel
reviewed
Feb 16, 2017
| @@ -158,7 +159,9 @@ class GatherRunner { | |||
| * @return {!Promise} | |||
| */ | |||
| static beforePass(options, gathererResults) { | |||
| const pass = GatherRunner.loadBlank(options.driver); | |||
| const blankPage = options.config.blankPage; | |||
There was a problem hiding this comment.
Since blank is how we referred to this concept before and WPT also uses the 'blank' nomenclature, I'd prefer to stick with it, but open to other ideas to make it clearer what's going on here. Any thoughts?
In fact, now that I think about it the page part doesn't make a lot of sense, blankUrl?
There was a problem hiding this comment.
Yea, not sure. blankStartPageUrl? haha. We should stick with the existing nomenclature though. I wasn't aware of that part.
paulirish
approved these changes
Feb 16, 2017
ebidel
approved these changes
Feb 17, 2017
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses parts of #1730
would be used in conjunction with #1731
usage