Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not fail if chrome could not be killed #1735

Merged
merged 2 commits into from
Feb 16, 2017
Merged

Conversation

patrickhulce
Copy link
Collaborator

should deflake the appveyor tests that have been failing ~50% of the time because of this

@paulirish paulirish merged commit 6fbfb24 into master Feb 16, 2017
@paulirish paulirish deleted the appveyor_deflake branch February 16, 2017 22:48
@XhmikosR
Copy link
Contributor

But why do they fail in the first place? Is this normal?

@patrickhulce
Copy link
Collaborator Author

@XhmikosR if I had to guess it's related to tab closing behavior and that there's a race between closing the tab which we don't wait for and killing Chrome. On Mac closing the last window does not usually quit the application, but the paradigm in Windows is usually to kill the process once the last window has been closed. In general, I think it's a bad idea to throw a fatal error for cleanup that has already been done.

@XhmikosR
Copy link
Contributor

I agree, I'm just wondering why this happens only on Windows and if it hides something else.

If the reason is what you suspect I guess it's OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants