Disable throttling for non-performance passes #1740
Conversation
lighthouse-core/gather/driver.js
Outdated
| @@ -673,21 +673,31 @@ class Driver { | |||
| return this.sendCommand('Runtime.enable'); | |||
| } | |||
|
|
|||
| beginEmulation(flags) { | |||
| beginEmulation(options) { | |||
There was a problem hiding this comment.
any reason to switch from flags to options? looks like this just uses flags
lighthouse-core/gather/driver.js
Outdated
| const emulations = []; | ||
|
|
||
| if (!flags.disableDeviceEmulation) { | ||
| emulations.push(emulation.enableNexus5X(this)); | ||
| if (!passConfig.useThrottling) { |
There was a problem hiding this comment.
this is one case I think having it nested would make it more readable, took me a bit to spot the early return (though that may be more diff noise and it's easier without the diff)
thoughts on the following?
if (useThrottling) {
if (!disableNetwork) emulations.push()
if (!disableCpu) emulations.push
} else {
emulations.push(...)
}
return Promise.all()
lighthouse-core/gather/driver.js
Outdated
| return this.sendCommand('Network.enable') | ||
| .then(_ => emulation.goOffline(this)) | ||
| .then(_ => { | ||
| this.online = false; |
There was a problem hiding this comment.
nit: could probably one-line this too
lighthouse-core/gather/driver.js
Outdated
| }); | ||
| } | ||
|
|
||
| setThrottling(cliFlags, passConfig) { |
There was a problem hiding this comment.
should passConfig just be a boolean, useThrottling?
There was a problem hiding this comment.
Ah, see you're passing in the options.config below. Guess it's fine.
paulirish
force-pushed
the
throttleallthetime
branch
2 times, most recently
from
12ae6de
to
d81792a
Compare
There was a problem hiding this comment.
PTAL. updated.
@patrickhulce good call inverting the conditional. much better now.
lighthouse-core/gather/driver.js
Outdated
| const emulations = []; | ||
|
|
||
| if (!flags.disableDeviceEmulation) { | ||
| emulations.push(emulation.enableNexus5X(this)); | ||
| if (!passConfig.useThrottling) { |
This is the approach that I ended up with after playing around a bit.
useThrottlingprop in the config for each passgoOnlinecomes back it'll restore whatever throttling should be for that pass.setThrottlingmethod in driver does the work. the oldbeginEmulationnow defers to it for some parts.wdyt?