Report: collapse aggregations when all audits pass

[ebidel]

R: @patrickhulce @paulirish

In the act of de-cluttering, this PR addresses some of of #1613 and implements the proposed solution in #1613 (comment).

Now, if all audits pass, the entire aggregation is collapsed. If one or more audits fail, the aggregation is opened up.

Before:

After:

when an audit fail:

BTW, the aggregation icons are slightly bigger than the subaudits. I thought the size difference was good but I'm happy to make them all the homogeneous.

• Aggregations now always create an overall score. Please look over those changes as I may have missed something.
• Adds css transitions to the details dropdown.
• @patrickhulce turns out the expectedValues/weights are important and we'll need to use them after all :) aggregate.js uses them to type check and calculate an overall score based on the weights.

[patrickhulce]

aggregate.js uses them to type check and calculate an overall score based on the weights

sure it uses them now ;) this is awesome though!

[paulirish]

Totally on board with the collapsing. Nice.

Regarding scoring, are you saying we'll now have scores for "Best practices" and "fancier stuff"?

[patrickhulce]

I thought this one actually was numeric, is it not?

[ebidel]

The rawValue that we display is numeric, yes. But we treat the audit as a pass/fail, which means expectedValue needs to be a boolean. AFAICT, expectedValue should really be expectedType.

[ebidel]

Regarding scoring, are you saying we'll now have scores for "Best practices" and "fancier stuff"?

Sorry. There's still only one score in the report (PWA). The difference with this PR is that it calculates an overall score for each subitem. That's not surfaced in the report though.

Before (all overall: 0 for unscored audits):

Now:

[patrickhulce]

After playing with it for a bit, I really like it, but the UX of the cards/boxes could use some work since I don't think it plays well with the collapsed report. Everything is rather succinct and cleanly laid out and the three large uncollapsible boxes really jump out. Can we have those collapse too?

[ebidel]

We can play with collapsing those too. Do you think if we use more cards in the report, it'll feel less jarring? Personally I like seeing them b/c it's something other than text.

[patrickhulce]

Yeah that's a fair point. Right now they just really stick out. If we used them more throughout I'd probably feel differently, but probably need to a strike a balance to prevent wall of text becoming wall of boxes :)

[paulirish]

Personally I like seeing them b/c it's something other than text.

Agree with that, but if those numbers are in good shape then it's not adding much value to always show them.
(Also maybe the target for each value should be in the card, as I don't know what numbers are good for children and depth)

[ebidel]

Added target vals support to the cards and they're now hidden by default. PTAL.

[paulirish]

SavageJ25 approves this pull request.

I mean... I'm sure he does, too.

(Thx for handling all the back n forth like a pro)

[ebidel]

@patrickhulce you happy too?

[patrickhulce]

Oh sorry yep!