Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report: clearer iconography in Perf metrics and Fancier Stuff #1750

Merged
merged 2 commits into from
Mar 1, 2017
Merged

Report: clearer iconography in Perf metrics and Fancier Stuff #1750

merged 2 commits into from
Mar 1, 2017

Conversation

sendilkumarn
Copy link
Contributor

clearer iconography fixes #1146

@sendilkumarn sendilkumarn reopened this Feb 19, 2017
@paulirish
Copy link
Member

paulirish commented Feb 23, 2017 •
edited
Loading

@sendilkumarn I'm somewhat following this, but not completely.
Can you post a short explanation and some screenshots?

@sendilkumarn
Copy link
Contributor Author

when an audit is informative and passes ℹ️ instead of ✅
screen shot 2017-02-24 at 9 28 37 am

when an aggregation is additional or audit is informative and fails ⚠️ instead of ❌
screen shot 2017-02-24 at 9 28 23 am

@paulirish paulirish mentioned this pull request Feb 24, 2017
Merged
@paulirish paulirish merged commit 60594cd into GoogleChrome:master Mar 1, 2017
@paulirish paulirish mentioned this pull request Mar 3, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulirish paulirish paulirish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Report: clearer iconography in Perf metrics and Fancier Stuff
2 participants
@sendilkumarn @paulirish