Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse existing tab if creating new tab fails #1760

Merged
merged 4 commits into from
Feb 23, 2017
Merged

Reuse existing tab if creating new tab fails #1760

merged 4 commits into from
Feb 23, 2017

Conversation

paulirish
Copy link
Member

Only happens in the CLI case, so far, as thats the only place we spawn a new tab.

Fixes #970

In this PR:

  • We move most of the impl of CriConnection.connect into _connectToSocket
  • We introduce a fallback mode if the this._runJsonCommand('new') rejects, where we reuse the first tab available.
  • We will make sure our chosen tab is in the foreground, as well.

@paulirish
Copy link
Member Author

This fixes the only major issue with headless chromium. \o/
@patrickhulce can you take a look tmw?

@paulirish paulirish merged commit 8c98de4 into master Feb 23, 2017
@paulirish paulirish deleted the newtabfallback branch February 23, 2017 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paulirish @patrickhulce