Add --view flag. Don't default CLI report to stdout. #1764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
approved these changes
Feb 23, 2017
| @@ -269,8 +273,15 @@ function saveResults(results: Results, | |||
| promise = promise.then(_ => assetSaver.saveAssets(artifacts, results.audits, resolvedPath)); | |||
| } | |||
|
|
|||
| if (flags.output === Printer.OutputMode[Printer.OutputMode.pretty]) { | |||
| promise = promise.then(_ => Printer.write(results, 'html', `${resolvedPath}.report.html`)); | |||
| if (flags.output === Printer.OutputMode[Printer.OutputMode.none]) { | |||
There was a problem hiding this comment.
Unfortunate that one cannot get both pretty output and HTML output now, but we're killing it entirely and #1714 captures multiple output desires anyway
|
@paulirish: is it expected that now if |
|
@XhmikosR yes that was a consequence of this change as noted in #1764 (comment) |
|
Ah, I see thanks. Not a big deal, but took me a while to see why it stopped to work. :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step in closing #1739 (Is it time to deprecate the CLI report output?)
--viewflag which will open the HTML report that the CLI generated in your default browser.outputchanges fromprettytonone, which means you dont get the full report flooding your terminal at the end. You can re-enable it with--output=pretty, however.