Rewrite chrome URLs to compare them. #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tommycli can you review? |
tommycli
approved these changes
Feb 28, 2017
|
Btw, I don't think I'm a valid reviewer. |
danbeam
approved these changes
Feb 28, 2017
ebidel
approved these changes
Feb 28, 2017
lighthouse-core/lib/url-shim.js
Outdated
| // As a result, the final document URL doesn't match the URL that network layer surfaces. | ||
| function rewriteChromeInternalUrl(url) { | ||
| if (!url.startsWith('chrome://')) return url; | ||
| return url.replace(/^chrome:\/\/chrome\//, 'chrome://'); |
There was a problem hiding this comment.
it't not clear from your description that it uses chrome:chrome urls. Might want to update the summary.
There was a problem hiding this comment.
good call. you got it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1776