Modernize sample.json test fixture according to latest output #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebidel
commented
Feb 28, 2017
| @@ -87,6 +87,8 @@ describe('Report', () => { | |||
| assert.ok(html.includes('data-action="save-json" '), 'has save json button'); | |||
| assert.ok(html.includes('class="report__icon copy"'), 'has copy button'); | |||
| assert.ok(html.includes('class="report__icon print"'), 'has print button'); | |||
| assert.ok(html.includes( | |||
There was a problem hiding this comment.
added to cover #1790 (comment) in the future.
ebidel
changed the title
|
Thanks! nice to have the sample.json up to date |
paulirish
approved these changes
Mar 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @paulirish @patrickhulce
Also removes the sample.json from lighthouse-cli. Not really much need for a duplicate file :)