Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging to extension driver. #182

Merged
merged 1 commit into from
Apr 12, 2016
Merged

Add logging to extension driver. #182

merged 1 commit into from
Apr 12, 2016

Conversation

paulirish
Copy link
Member

image

@samccone samccone added the +1 label Apr 12, 2016
@brendankenny
Copy link
Member

maybe file an issue for adding support for logging levels when in the extension and using console.log?

@brendankenny
Copy link
Member

LGTM, but let's wait on #156 so it doesn't have to rebase again

@brendankenny brendankenny mentioned this pull request Apr 12, 2016
Merged
3 tasks
@brendankenny
Copy link
Member

looks like no merging conflicts

@brendankenny brendankenny merged commit 8e7d651 into GoogleChrome:master Apr 12, 2016
@paulirish
Copy link
Member Author

maybe file an issue for adding support for logging levels when in the extension and using console.log?

because its only visible when debugging the background page i think its lower priority, but if anyone feels strongly we can put it on the backlog.

@paulirish paulirish deleted the extensionlogging branch April 24, 2016 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paulirish @brendankenny @samccone