Fix: Replace npm with yarn on travis #2067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
changed the title
|
Hmm, not sure why that test failed. Didn't fail when it ran for my fork's travis job. Perhaps the caching is causing the test to be flaky? /shrug |
|
looks like it was our perpetually flakey test. Did a rerun and green now :) |
|
Ok for me, I believe everyone is using it locally anyway. |
paulirish
approved these changes
Apr 26, 2017
|
@stramel thanks so much! appreciate this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoping this addresses #2048 Not too familiar with Yarn. Did get passing tests on travis though.