Migrate all dev scripts + docs from npm to yarn. #2072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebidel
reviewed
Apr 26, 2017
.travis.yml
Outdated
| before_script: | ||
| - gem install travis-artifacts | ||
| - export DISPLAY=:99.0 | ||
| - export LIGHTHOUSE_CHROMIUM_PATH="$(pwd)/chrome-linux/chrome" | ||
| - sh -e /etc/init.d/xvfb start | ||
| - ./lighthouse-core/scripts/download-chrome.sh | ||
| - npm run build-all | ||
| - yarn run build-all |
There was a problem hiding this comment.
Pretty sure the "run" is optional.
yarn blah would be great for all the things.
There was a problem hiding this comment.
ya it is. i was keeping it in some places to be explicit, but really i'd prefer to go without "run", too. :)
i'll nuke them.
ebidel
approved these changes
Apr 26, 2017
Users can install install with npm, though
ebidel
approved these changes
Apr 26, 2017
| @@ -238,13 +238,12 @@ right corner and signing in to GitHub. | |||
| git clone https://github.com/GoogleChrome/lighthouse | |||
|
|
|||
There was a problem hiding this comment.
we should add a note about needing yarn for development here
paulirish
added a commit
that referenced
this pull request
Apr 26, 2017
Users can install install with npm, though
paulirish
added a commit
that referenced
this pull request
Apr 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users are very welcome to install lighthouse with npm, but if they're doing a clone and any local development, all scripts + docs use yarn.